CB-10636 Add JSHint for plugins

.gitignore

@@ -12,7 +12,7 @@ Thumbs.db
 *.swp
 *.user
 
-
+node_modules
 
 
 

.jshintrc

@@ -0,0 +1,17 @@
+{
+    "browser": true
+  , "devel": true
+  , "bitwise": true
+  , "undef": true
+  , "trailing": true
+  , "quotmark": false
+  , "indent": 4
+  , "unused": "vars"
+  , "latedef": "nofunc"
+  , "globals": {
+        "module": false,
+        "exports": false,
+        "require": false,
+        "cordova": true
+    }
+}

.travis.yml

@@ -0,0 +1,4 @@
+language: node_js
+sudo: false
+node_js:
+  - "4.2"

README.md

@@ -17,6 +17,8 @@
 #         under the License.
 -->
 
+[![Build Status](https://travis-ci.org/apache/cordova-plugin-network-information.svg?branch=master)](https://travis-ci.org/apache/cordova-plugin-network-information)
+
 # cordova-plugin-network-information
 
 

package.json

@@ -41,6 +41,13 @@
     "cordova-tizen",
     "cordova-browser"
   ],
+  "scripts": {
+    "test": "npm run jshint",
+    "jshint": "jshint www && jshint src && jshint tests"
+  },
   "author": "Apache Software Foundation",
-  "license": "Apache-2.0"
+  "license": "Apache-2.0",
+  "devDependencies": {
+    "jshint": "^2.6.0"
+  }
 }

src/blackberry10/index.js

@@ -19,6 +19,8 @@
  *
 */
 
+/* global PluginResult */
+
 //map from BB10 to cordova connection types:
 //https://github.com/apache/cordova-js/blob/master/lib/common/plugin/Connection.js
 function mapConnectionType(con) {

src/browser/network.js

@@ -18,8 +18,6 @@
  *
 */
 
-/*global module, require*/
-
 var cordova = require('cordova'),
     proxy = require("cordova/exec/proxy"),
     Connection = require('./Connection');

src/firefoxos/NetworkProxy.js

@@ -24,8 +24,7 @@
   and http://w3c.github.io/netinfo/
 */
 
-var cordova = require('cordova'),
+var Connection = require('./Connection'),
-    Connection = require('./Connection'),
     modulemapper = require('cordova/modulemapper');
 
 var origConnection = modulemapper.getOriginalSymbol(window, 'navigator.connection');
@@ -47,7 +46,7 @@ module.exports = {
       metered = connection.metered,
       type = connection.type;
 
-    if (type != undefined) {
+    if (type !== undefined) {
       // For more information see:
       // https://developer.mozilla.org/en-US/docs/Web/API/Network_Information_API
 
@@ -65,7 +64,7 @@ module.exports = {
           connectionType = Connection.NONE;
           break;
       }
-    } else if (bandwidth != undefined && metered != undefined) {
+    } else if (bandwidth !== undefined && metered !== undefined) {
       /*
       bandwidth of type double, readonly
       The user agent must set the value of the bandwidth attribute to:

src/tizen/NetworkProxy.js

@@ -19,7 +19,8 @@
  *
 */
 
-var cordova = require('cordova');
+/* global tizen */
+
 var Connection = require('./Connection');
 
 module.exports = {

src/windows/NetworkInfoProxy.js

@@ -21,15 +21,10 @@
 
 /*global Windows:true */
 
-var cordova = require('cordova');
 var Connection = require('./Connection');
 
 var winNetConn = Windows.Networking.Connectivity;
 var networkInfo = winNetConn.NetworkInformation;
-var networkCostInfo = winNetConn.NetworkCostType;
-var networkConnectivityInfo = winNetConn.NetworkConnectivityLevel;
-var networkAuthenticationInfo = winNetConn.NetworkAuthenticationType;
-var networkEncryptionInfo = winNetConn.NetworkEncryptionType;
 
 function getCurrrentConnectionType() {
 
@@ -76,7 +71,7 @@ module.exports = {
     {
         var reportConnectionInfoOnce = function () {
             win(getCurrrentConnectionType(), { keepCallback: true });
-        }
+        };
 
         // report current connection  type
         setTimeout(reportConnectionInfoOnce, 0);

tests/tests.js

@@ -19,6 +19,9 @@
  *
 */
 
+/* jshint jasmine: true */
+/* global Connection */
+
 exports.defineAutoTests = function () {
     describe('Network (navigator.connection)', function () {
         it("network.spec.1 should exist", function () {