public/cordova-plugin-network-information
public/cordova-plugin-network-information
9
0
Fork 0
mirror of https://gitee.com/shuto/cordova-plugin-network-information.git synced 2025-01-31 10:35:43 +08:00
Code Issues Projects Releases Wiki Activity

CB-11838 ios: Unregister callback function at the right timing.

Browse Source 
We at LINE observed about 40K crashes a day that were suspected to be
caused by the reacahability callback function invoked on an
already-deallocated object. We couldn't reproduced the crash locally
but this patch did reduce the number of crash reports to zero.

 This closes #49
This commit is contained in:
Ken'ichi Fukushima 2016-09-12 18:28:49 +09:00 committed by Julio César
parent ee0cb16e58
commit f4f1abec3a
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ios/CDVReachability.m
View File

@ -120,6 +120,7 @@ static void CDVReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRe
- (void)stopNotifier - (void)stopNotifier
{ {
if (reachabilityRef != NULL) { if (reachabilityRef != NULL) {
SCNetworkReachabilitySetCallback(reachabilityRef, NULL, NULL);
SCNetworkReachabilityUnscheduleFromRunLoop(reachabilityRef, CFRunLoopGetCurrent(), kCFRunLoopDefaultMode); SCNetworkReachabilityUnscheduleFromRunLoop(reachabilityRef, CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
} }
} }