CB-12985 : setup eslint and removed jshint

.eslintrc.yml

@@ -0,0 +1,10 @@
+root: true
+extends: semistandard
+rules:
+  indent:
+    - error
+    - 4
+  camelcase: off
+  padded-blocks: off
+  operator-linebreak: off
+  no-throw-literal: off

.jshintrc

@@ -1,16 +0,0 @@
-{
-    "browser": true
-  , "devel": true
-  , "bitwise": true
-  , "undef": true
-  , "trailing": true
-  , "quotmark": false
-  , "indent": 4
-  , "unused": "vars"
-  , "latedef": "nofunc"
-  , "globals": {
-        "module": false,
-        "exports": false,
-        "require": false
-    }
-}

package.json

@@ -45,8 +45,8 @@
   "scripts": {
     "precommit": "npm run gen-docs && git add README.md",
     "gen-docs": "jsdoc2md --template \"jsdoc2md/TEMPLATE.md\" \"www/**/*.js\" --plugin \"dmd-plugin-cordova-plugin\" > README.md",
-    "test": "npm run jshint",
+    "test": "npm run eslint",
-    "jshint": "node node_modules/jshint/bin/jshint www && node node_modules/jshint/bin/jshint src && node node_modules/jshint/bin/jshint tests"
+    "eslint": "node node_modules/eslint/bin/eslint www && node node_modules/eslint/bin/eslint src && node node_modules/eslint/bin/eslint tests"
   },
   "author": "Apache Software Foundation",
   "license": "Apache-2.0",
@@ -59,8 +59,14 @@
   },
   "devDependencies": {
     "dmd-plugin-cordova-plugin": "^0.1.0",
+    "eslint": "^4.2.0",
+    "eslint-config-semistandard": "^11.0.0",
+    "eslint-config-standard": "^10.2.1",
+    "eslint-plugin-import": "^2.3.0",
+    "eslint-plugin-node": "^5.0.0",
+    "eslint-plugin-promise": "^3.5.0",
+    "eslint-plugin-standard": "^3.0.1",
     "husky": "^0.10.1",
-    "jsdoc-to-markdown": "^1.2.0",
+    "jsdoc-to-markdown": "^1.2.0"
-    "jshint": "^2.6.0"
   }
 }

src/blackberry10/index.js

@@ -31,7 +31,7 @@ var PictureSourceType = {
         FILE_URI: 1,         // Return file uri (content://media/external/images/media/2 for Android)
         NATIVE_URI: 2        // Return native uri (eg. asset-library://... for iOS)
     },
-    savePath = window.qnx.webplatform.getApplication().getEnv("HOME").replace('/data', '') + '/shared/camera/',
+    savePath = window.qnx.webplatform.getApplication().getEnv('HOME').replace('/data', '') + '/shared/camera/',
     invokeAvailable = true;
 
 // check for camera card - it isn't currently availble in work perimeter
@@ -126,27 +126,27 @@ function saveImage(data, success, fail) {
 function encodeBase64 (filePath, callback) {
     var sandbox = window.qnx.webplatform.getController().setFileSystemSandbox, // save original sandbox value
         errorHandler = function (err) {
-            var msg = "An error occured: ";
+            var msg = 'An error occured: ';
 
             switch (err.code) {
             case FileError.NOT_FOUND_ERR:
-                msg += "File or directory not found";
+                msg += 'File or directory not found';
                 break;
 
             case FileError.NOT_READABLE_ERR:
-                msg += "File or directory not readable";
+                msg += 'File or directory not readable';
                 break;
 
             case FileError.PATH_EXISTS_ERR:
-                msg += "File or directory already exists";
+                msg += 'File or directory already exists';
                 break;
 
             case FileError.TYPE_MISMATCH_ERR:
-                msg += "Invalid file type";
+                msg += 'Invalid file type';
                 break;
 
             default:
-                msg += "Unknown Error";
+                msg += 'Unknown Error';
                 break;
             }
 
@@ -182,12 +182,12 @@ module.exports = {
             result = new PluginResult(args, env),
             done = function (data) {
                 if (destinationType === DestinationType.FILE_URI) {
-                    data = "file://" + data;
+                    data = 'file://' + data;
                     result.callbackOk(data, false);
                 } else {
                     encodeBase64(data, function (data) {
                         if (/^data:/.test(data)) {
-                            data = data.slice(data.indexOf(",") + 1);
+                            data = data.slice(data.indexOf(',') + 1);
                             result.callbackOk(data, false);
                         } else {
                             result.callbackError(data, false);
@@ -207,7 +207,7 @@ module.exports = {
         switch (sourceType) {
         case PictureSourceType.CAMERA:
             if (invokeAvailable) {
-                window.qnx.webplatform.getApplication().cards.camera.open("photo", done, cancel, invoked);
+                window.qnx.webplatform.getApplication().cards.camera.open('photo', done, cancel, invoked);
             } else {
                 showCameraDialog(done, cancel, fail);
             }
@@ -216,8 +216,8 @@ module.exports = {
         case PictureSourceType.PHOTOLIBRARY:
         case PictureSourceType.SAVEDPHOTOALBUM:
             window.qnx.webplatform.getApplication().cards.filePicker.open({
-                mode: "Picker",
+                mode: 'Picker',
-                type: ["picture"]
+                type: ['picture']
             }, done, cancel, invoked);
             break;
         }

src/browser/CameraProxy.js

@@ -120,4 +120,4 @@ module.exports = {
     cleanup: function () {}
 };
 
-require("cordova/exec/proxy").add("Camera",module.exports);
+require('cordova/exec/proxy').add('Camera', module.exports);

src/firefoxos/CameraProxy.js

@@ -23,9 +23,9 @@
 
 function takePicture (success, error, opts) {
     var pick = new MozActivity({
-        name: "pick",
+        name: 'pick',
         data: {
-            type: ["image/*"]
+            type: ['image/*']
         }
     });
 
@@ -50,4 +50,4 @@ module.exports = {
     cleanup: function () {}
 };
 
-require("cordova/exec/proxy").add("Camera", module.exports);
+require('cordova/exec/proxy').add('Camera', module.exports);

src/windows/CameraProxy.js

@@ -22,10 +22,8 @@
 /* jshint unused:true, undef:true, browser:true */
 /* global Windows:true, URL:true, module:true, require:true, WinJS:true */
 
-
 var Camera = require('./Camera');
 
-
 var getAppData = function () {
     return Windows.Storage.ApplicationData.current;
 };
@@ -67,8 +65,8 @@ module.exports = {
 };
 
 // https://msdn.microsoft.com/en-us/library/windows/apps/ff462087(v=vs.105).aspx
-var windowsVideoContainers = [".avi", ".flv", ".asx", ".asf", ".mov", ".mp4", ".mpg", ".rm", ".srt", ".swf", ".wmv", ".vob"];
+var windowsVideoContainers = ['.avi', '.flv', '.asx', '.asf', '.mov', '.mp4', '.mpg', '.rm', '.srt', '.swf', '.wmv', '.vob'];
-var windowsPhoneVideoContainers =  [".avi", ".3gp", ".3g2", ".wmv", ".3gp", ".3g2", ".mp4", ".m4v"];
+var windowsPhoneVideoContainers = ['.avi', '.3gp', '.3g2', '.wmv', '.3gp', '.3g2', '.mp4', '.m4v'];
 
 // Default aspect ratio 1.78 (16:9 hd video standard)
 var DEFAULT_ASPECT_RATIO = '1.8';
@@ -78,15 +76,15 @@ var HIGHEST_POSSIBLE_Z_INDEX = 2147483647;
 
 // Resize method
 function resizeImage (successCallback, errorCallback, file, targetWidth, targetHeight, encodingType) {
-    var tempPhotoFileName = "";
+    var tempPhotoFileName = '';
-    var targetContentType = "";
+    var targetContentType = '';
 
     if (encodingType == Camera.EncodingType.PNG) {
-        tempPhotoFileName = "camera_cordova_temp_return.png";
+        tempPhotoFileName = 'camera_cordova_temp_return.png';
-        targetContentType = "image/png";
+        targetContentType = 'image/png';
     } else {
-        tempPhotoFileName = "camera_cordova_temp_return.jpg";
+        tempPhotoFileName = 'camera_cordova_temp_return.jpg';
-        targetContentType = "image/jpeg";
+        targetContentType = 'image/jpeg';
     }
 
     var storageFolder = getAppData().localFolder;
@@ -96,7 +94,7 @@ function resizeImage(successCallback, errorCallback, file, targetWidth, targetHe
         })
         .then(function (buffer) {
             var strBase64 = encodeToBase64String(buffer);
-            var imageData = "data:" + file.contentType + ";base64," + strBase64;
+            var imageData = 'data:' + file.contentType + ';base64,' + strBase64;
             var image = new Image();
             image.src = imageData;
             image.onload = function () {
@@ -110,7 +108,7 @@ function resizeImage(successCallback, errorCallback, file, targetWidth, targetHe
                 canvas.width = imageWidth;
                 canvas.height = imageHeight;
 
-                canvas.getContext("2d").drawImage(this, 0, 0, imageWidth, imageHeight);
+                canvas.getContext('2d').drawImage(this, 0, 0, imageWidth, imageHeight);
 
                 var fileContent = canvas.toDataURL(targetContentType).split(',')[1];
 
@@ -123,7 +121,7 @@ function resizeImage(successCallback, errorCallback, file, targetWidth, targetHe
                         return fileIO.writeBufferAsync(storagefile, content);
                     })
                     .done(function () {
-                        successCallback("ms-appdata:///local/" + storageFileName);
+                        successCallback('ms-appdata:///local/' + storageFileName);
                     }, errorCallback);
             };
         })
@@ -137,7 +135,7 @@ function resizeImage(successCallback, errorCallback, file, targetWidth, targetHe
 function resizeImageBase64 (successCallback, errorCallback, file, targetWidth, targetHeight) {
     fileIO.readBufferAsync(file).done(function (buffer) {
         var strBase64 = encodeToBase64String(buffer);
-        var imageData = "data:" + file.contentType + ";base64," + strBase64;
+        var imageData = 'data:' + file.contentType + ';base64,' + strBase64;
 
         var image = new Image();
         image.src = imageData;
@@ -151,14 +149,14 @@ function resizeImageBase64(successCallback, errorCallback, file, targetWidth, ta
             canvas.width = imageWidth;
             canvas.height = imageHeight;
 
-            var ctx = canvas.getContext("2d");
+            var ctx = canvas.getContext('2d');
             ctx.drawImage(this, 0, 0, imageWidth, imageHeight);
 
             // The resized file ready for upload
             var finalFile = canvas.toDataURL(file.contentType);
 
             // Remove the prefix such as "data:" + contentType + ";base64," , in order to meet the Cordova API.
-            var arr = finalFile.split(",");
+            var arr = finalFile.split(',');
             var newStr = finalFile.substr(arr[0].length + 1);
             successCallback(newStr);
         };
@@ -191,28 +189,25 @@ function takePictureFromFileWP(successCallback, errorCallback, args) {
             var file = eventArgs.files[0];
             if (!file) {
                 errorCallback("User didn't choose a file.");
-                webUIApp.removeEventListener("activated", filePickerActivationHandler);
+                webUIApp.removeEventListener('activated', filePickerActivationHandler);
                 return;
             }
             if (destinationType == Camera.DestinationType.FILE_URI || destinationType == Camera.DestinationType.NATIVE_URI) {
                 if (targetHeight > 0 && targetWidth > 0) {
                     resizeImage(successCallback, errorCallback, file, targetWidth, targetHeight, encodingType);
-                }
+                } else {
-                else {
                     var storageFolder = getAppData().localFolder;
                     file.copyAsync(storageFolder, file.name, Windows.Storage.NameCollisionOption.replaceExisting).done(function (storageFile) {
                         if (destinationType == Camera.DestinationType.NATIVE_URI) {
-                            successCallback("ms-appdata:///local/" + storageFile.name);
+                            successCallback('ms-appdata:///local/' + storageFile.name);
-                        }
+                        } else {
-                        else {
                             successCallback(URL.createObjectURL(storageFile));
                         }
                     }, function () {
                         errorCallback("Can't access localStorage folder.");
                     });
                 }
-            }
+            } else {
-            else {
                 if (targetHeight > 0 && targetWidth > 0) {
                     resizeImageBase64(successCallback, errorCallback, file, targetWidth, targetHeight);
                 } else {
@@ -222,25 +217,23 @@ function takePictureFromFileWP(successCallback, errorCallback, args) {
                     }, errorCallback);
                 }
             }
-            webUIApp.removeEventListener("activated", filePickerActivationHandler);
+            webUIApp.removeEventListener('activated', filePickerActivationHandler);
         }
     };
 
     var fileOpenPicker = new Windows.Storage.Pickers.FileOpenPicker();
     if (mediaType == Camera.MediaType.PICTURE) {
-        fileOpenPicker.fileTypeFilter.replaceAll([".png", ".jpg", ".jpeg"]);
+        fileOpenPicker.fileTypeFilter.replaceAll(['.png', '.jpg', '.jpeg']);
         fileOpenPicker.suggestedStartLocation = pickerLocId.picturesLibrary;
-    }
+    } else if (mediaType == Camera.MediaType.VIDEO) {
-    else if (mediaType == Camera.MediaType.VIDEO) {
         fileOpenPicker.fileTypeFilter.replaceAll(windowsPhoneVideoContainers);
         fileOpenPicker.suggestedStartLocation = pickerLocId.videosLibrary;
-    }
+    } else {
-    else {
+        fileOpenPicker.fileTypeFilter.replaceAll(['*']);
-        fileOpenPicker.fileTypeFilter.replaceAll(["*"]);
         fileOpenPicker.suggestedStartLocation = pickerLocId.documentsLibrary;
     }
 
-    webUIApp.addEventListener("activated", filePickerActivationHandler);
+    webUIApp.addEventListener('activated', filePickerActivationHandler);
     fileOpenPicker.pickSingleFileAndContinue();
 }
 
@@ -253,15 +246,13 @@ function takePictureFromFileWindows(successCallback, errorCallback, args) {
 
     var fileOpenPicker = new Windows.Storage.Pickers.FileOpenPicker();
     if (mediaType == Camera.MediaType.PICTURE) {
-        fileOpenPicker.fileTypeFilter.replaceAll([".png", ".jpg", ".jpeg"]);
+        fileOpenPicker.fileTypeFilter.replaceAll(['.png', '.jpg', '.jpeg']);
         fileOpenPicker.suggestedStartLocation = pickerLocId.picturesLibrary;
-    }
+    } else if (mediaType == Camera.MediaType.VIDEO) {
-    else if (mediaType == Camera.MediaType.VIDEO) {
         fileOpenPicker.fileTypeFilter.replaceAll(windowsVideoContainers);
         fileOpenPicker.suggestedStartLocation = pickerLocId.videosLibrary;
-    }
+    } else {
-    else {
+        fileOpenPicker.fileTypeFilter.replaceAll(['*']);
-        fileOpenPicker.fileTypeFilter.replaceAll(["*"]);
         fileOpenPicker.suggestedStartLocation = pickerLocId.documentsLibrary;
     }
 
@@ -273,22 +264,19 @@ function takePictureFromFileWindows(successCallback, errorCallback, args) {
         if (destinationType == Camera.DestinationType.FILE_URI || destinationType == Camera.DestinationType.NATIVE_URI) {
             if (targetHeight > 0 && targetWidth > 0) {
                 resizeImage(successCallback, errorCallback, file, targetWidth, targetHeight, encodingType);
-            }
+            } else {
-            else {
                 var storageFolder = getAppData().localFolder;
                 file.copyAsync(storageFolder, file.name, Windows.Storage.NameCollisionOption.replaceExisting).done(function (storageFile) {
                     if (destinationType == Camera.DestinationType.NATIVE_URI) {
-                            successCallback("ms-appdata:///local/" + storageFile.name);
+                        successCallback('ms-appdata:///local/' + storageFile.name);
-                        }
+                    } else {
-                        else {
                         successCallback(URL.createObjectURL(storageFile));
                     }
                 }, function () {
                     errorCallback("Can't access localStorage folder.");
                 });
             }
-        }
+        } else {
-        else {
             if (targetHeight > 0 && targetWidth > 0) {
                 resizeImageBase64(successCallback, errorCallback, file, targetWidth, targetHeight);
             } else {
@@ -331,23 +319,23 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
 
     function createCameraUI () {
         // create style for take and cancel buttons
-        var buttonStyle = "width:45%;padding: 10px 16px;font-size: 18px;line-height: 1.3333333;color: #333;background-color: #fff;border-color: #ccc; border: 1px solid transparent;border-radius: 6px; display: block; margin: 20px; z-index: 1000;border-color: #adadad;";
+        var buttonStyle = 'width:45%;padding: 10px 16px;font-size: 18px;line-height: 1.3333333;color: #333;background-color: #fff;border-color: #ccc; border: 1px solid transparent;border-radius: 6px; display: block; margin: 20px; z-index: 1000;border-color: #adadad;';
 
         // Create fullscreen preview
         // z-order style element for capturePreview and cameraCancelButton elts
         // is necessary to avoid overriding by another page elements, -1 sometimes is not enough
-        capturePreview = document.createElement("video");
+        capturePreview = document.createElement('video');
-        capturePreview.style.cssText = "position: fixed; left: 0; top: 0; width: 100%; height: 100%; z-index: " + (HIGHEST_POSSIBLE_Z_INDEX - 1) + ";";
+        capturePreview.style.cssText = 'position: fixed; left: 0; top: 0; width: 100%; height: 100%; z-index: ' + (HIGHEST_POSSIBLE_Z_INDEX - 1) + ';';
 
         // Create capture button
-        cameraCaptureButton = document.createElement("button");
+        cameraCaptureButton = document.createElement('button');
-        cameraCaptureButton.innerText = "Take";
+        cameraCaptureButton.innerText = 'Take';
-        cameraCaptureButton.style.cssText = buttonStyle + "position: fixed; left: 0; bottom: 0; margin: 20px; z-index: " + HIGHEST_POSSIBLE_Z_INDEX + ";";
+        cameraCaptureButton.style.cssText = buttonStyle + 'position: fixed; left: 0; bottom: 0; margin: 20px; z-index: ' + HIGHEST_POSSIBLE_Z_INDEX + ';';
 
         // Create cancel button
-        cameraCancelButton = document.createElement("button");
+        cameraCancelButton = document.createElement('button');
-        cameraCancelButton.innerText = "Cancel";
+        cameraCancelButton.innerText = 'Cancel';
-        cameraCancelButton.style.cssText = buttonStyle + "position: fixed; right: 0; bottom: 0; margin: 20px; z-index: " + HIGHEST_POSSIBLE_Z_INDEX + ";";
+        cameraCancelButton.style.cssText = buttonStyle + 'position: fixed; right: 0; bottom: 0; margin: 20px; z-index: ' + HIGHEST_POSSIBLE_Z_INDEX + ';';
 
         capture = new CaptureNS.MediaCapture();
 
@@ -369,7 +357,7 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
         var expectedPanel = cameraDirection === 1 ? DeviceEnum.Panel.front : DeviceEnum.Panel.back;
 
         // Add focus event handler to capture the event when user suspends the app and comes back while the preview is on
-        window.addEventListener("focus", continueVideoOnFocus);
+        window.addEventListener('focus', continueVideoOnFocus);
 
         DeviceEnum.DeviceInformation.findAllAsync(DeviceEnum.DeviceClass.videoCapture).then(function (devices) {
             if (devices.length <= 0) {
@@ -418,7 +406,7 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
             // Bind events to controls
             sensor = Windows.Devices.Sensors.SimpleOrientationSensor.getDefault();
             if (sensor !== null) {
-                sensor.addEventListener("orientationchanged", onOrientationChange);
+                sensor.addEventListener('orientationchanged', onOrientationChange);
             }
 
             // add click events to capture and cancel buttons
@@ -474,7 +462,7 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
         cameraCancelButton.removeEventListener('click', onCameraCancelButtonClick);
 
         // Remove the focus event handler
-        window.removeEventListener("focus", continueVideoOnFocus);
+        window.removeEventListener('focus', continueVideoOnFocus);
 
         // Remove elements
         [capturePreview, cameraCaptureButton, cameraCancelButton].forEach(function (elem) {
@@ -535,7 +523,7 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
                         }, function () {
                             photoStream.close();
                             finalStream.close();
-                            throw new Error("An error has occured while capturing the photo.");
+                            throw new Error('An error has occured while capturing the photo.');
                         });
                 });
             })
@@ -752,7 +740,7 @@ function takePictureFromCameraWindows(successCallback, errorCallback, args) {
 
     // define focus handler for windows phone 10.0
     var savePhotoOnFocus = function () {
-        window.removeEventListener("focus", savePhotoOnFocus);
+        window.removeEventListener('focus', savePhotoOnFocus);
         // call only when the app is in focus again
         savePhoto(cameraPicture, {
             destinationType: destinationType,
@@ -765,14 +753,14 @@ function takePictureFromCameraWindows(successCallback, errorCallback, args) {
 
     // if windows phone 10, add and delete focus eventHandler to capture the focus back from cameraUI to app
     if (navigator.appVersion.indexOf('Windows Phone 10.0') >= 0) {
-        window.addEventListener("focus", savePhotoOnFocus);
+        window.addEventListener('focus', savePhotoOnFocus);
     }
 
     cameraCaptureUI.captureFileAsync(WMCapture.CameraCaptureUIMode.photo).done(function (picture) {
         if (!picture) {
             errorCallback("User didn't capture a photo.");
             // Remove the focus handler if present
-            window.removeEventListener("focus", savePhotoOnFocus);
+            window.removeEventListener('focus', savePhotoOnFocus);
             return;
         }
         cameraPicture = picture;
@@ -788,8 +776,8 @@ function takePictureFromCameraWindows(successCallback, errorCallback, args) {
             }, successCallback, errorCallback);
         }
     }, function () {
-        errorCallback("Fail to capture a photo.");
+        errorCallback('Fail to capture a photo.');
-        window.removeEventListener("focus", savePhotoOnFocus);
+        window.removeEventListener('focus', savePhotoOnFocus);
     });
 }
 
@@ -801,7 +789,7 @@ function savePhoto(picture, options, successCallback, errorCallback) {
                 resizeImage(successCallback, errorCallback, picture, options.targetWidth, options.targetHeight, options.encodingType);
             } else {
                 picture.copyAsync(getAppData().localFolder, picture.name, OptUnique).done(function (copiedFile) {
-                    successCallback("ms-appdata:///local/" + copiedFile.name);
+                    successCallback('ms-appdata:///local/' + copiedFile.name);
                 }, errorCallback);
             }
         } else {
@@ -822,7 +810,7 @@ function savePhoto(picture, options, successCallback, errorCallback) {
 
     if (!options.saveToPhotoAlbum) {
         success(picture);
-        return;
+
     } else {
         var savePicker = new Windows.Storage.Pickers.FileSavePicker();
         var saveFile = function (file) {
@@ -839,21 +827,21 @@ function savePhoto(picture, options, successCallback, errorCallback) {
                         if (updateStatus === Windows.Storage.Provider.FileUpdateStatus.complete) {
                             success(picture);
                         } else {
-                            errorCallback("File update status is not complete.");
+                            errorCallback('File update status is not complete.');
                         }
                     }, errorCallback);
             } else {
-                errorCallback("Failed to select a file.");
+                errorCallback('Failed to select a file.');
             }
         };
         savePicker.suggestedStartLocation = pickerLocId.picturesLibrary;
 
         if (options.encodingType === Camera.EncodingType.PNG) {
-            savePicker.fileTypeChoices.insert("PNG", [".png"]);
+            savePicker.fileTypeChoices.insert('PNG', ['.png']);
-            savePicker.suggestedFileName = "photo.png";
+            savePicker.suggestedFileName = 'photo.png';
         } else {
-            savePicker.fileTypeChoices.insert("JPEG", [".jpg"]);
+            savePicker.fileTypeChoices.insert('JPEG', ['.jpg']);
-            savePicker.suggestedFileName = "photo.jpg";
+            savePicker.suggestedFileName = 'photo.jpg';
         }
 
         // If Windows Phone 8.1 use pickSaveFileAndContinue()
@@ -867,10 +855,10 @@ function savePhoto(picture, options, successCallback, errorCallback) {
                 if (eventArgs.kind === Windows.ApplicationModel.Activation.ActivationKind.pickSaveFileContinuation) {
                     var file = eventArgs.file;
                     saveFile(file);
-                    webUIApp.removeEventListener("activated", fileSaveHandler);
+                    webUIApp.removeEventListener('activated', fileSaveHandler);
                 }
             };
-            webUIApp.addEventListener("activated", fileSaveHandler);
+            webUIApp.addEventListener('activated', fileSaveHandler);
             savePicker.pickSaveFileAndContinue();
         } else {
             savePicker.pickSaveFileAsync()
@@ -879,4 +867,4 @@ function savePhoto(picture, options, successCallback, errorCallback) {
     }
 }
 
-require("cordova/exec/proxy").add("Camera",module.exports);
+require('cordova/exec/proxy').add('Camera', module.exports);

www/Camera.js

@@ -19,9 +19,9 @@
  *
 */
 
-var argscheck = require('cordova/argscheck'),
+var argscheck = require('cordova/argscheck');
-    exec = require('cordova/exec'),
+var exec = require('cordova/exec');
-    Camera = require('./Camera');
+var Camera = require('./Camera');
 // XXX: commented out
 // CameraPopoverHandle = require('./CameraPopoverHandle');
 
@@ -152,7 +152,7 @@ cameraExport.getPicture = function(successCallback, errorCallback, options) {
     var args = [quality, destinationType, sourceType, targetWidth, targetHeight, encodingType,
         mediaType, allowEdit, correctOrientation, saveToPhotoAlbum, popoverOptions, cameraDirection];
 
-    exec(successCallback, errorCallback, "Camera", "takePicture", args);
+    exec(successCallback, errorCallback, 'Camera', 'takePicture', args);
     // XXX: commented out
     // return new CameraPopoverHandle();
 };
@@ -179,7 +179,7 @@ cameraExport.getPicture = function(successCallback, errorCallback, options) {
  * }
  */
 cameraExport.cleanup = function (successCallback, errorCallback) {
-    exec(successCallback, errorCallback, "Camera", "cleanup", []);
+    exec(successCallback, errorCallback, 'Camera', 'cleanup', []);
 };
 
 module.exports = cameraExport;

www/blackberry10/assets/camera.js

@@ -25,9 +25,9 @@ document.addEventListener('DOMContentLoaded', function () {
     window.navigator.webkitGetUserMedia(
         { video: true },
         function (stream) {
-            var video = document.getElementById('v'),
+            var video = document.getElementById('v');
-                canvas = document.getElementById('c'),
+            var canvas = document.getElementById('c');
-                camera = document.getElementById('camera');
+            var camera = document.getElementById('camera');
             video.autoplay = true;
             video.width = window.innerWidth;
             video.height = window.innerHeight - 100;

www/ios/CameraPopoverHandle.js

@@ -59,7 +59,7 @@ var CameraPopoverHandle = function() {
      */
     this.setPosition = function (popoverOptions) {
         var args = [ popoverOptions ];
-        exec(null, null, "Camera", "repositionPopover", args);
+        exec(null, null, 'Camera', 'repositionPopover', args);
     };
 };