zhaidi/cordova-plugin-inappbrowser
zhaidi/cordova-plugin-inappbrowser
1
0
Fork 0
forked from public/cordova-plugin-inappbrowser
Code Pull Requests Activity

GH-417: Handle non-default target attribute values (e.g. target=on links in WKWebView implementation on iOS (#418)

Browse Source
This commit is contained in:
Dave Alden 2019-02-10 17:06:35 +00:00 committed by Jan Piotrowski
parent 6db2f2d324
commit 9f4b72982a
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ios/CDVWKInAppBrowser.m
View File

@ -573,7 +573,14 @@ static CDVWKInAppBrowser* instance = nil;
} }
if(shouldStart){ if(shouldStart){
decisionHandler(WKNavigationActionPolicyAllow); // Fix GH-417: Handle non-default target attribute
// Based on https://stackoverflow.com/a/25853806/777265
if (!navigationAction.targetFrame.isMainFrame){
[theWebView loadRequest:navigationAction.request];
decisionHandler(WKNavigationActionPolicyCancel);
}else{
decisionHandler(WKNavigationActionPolicyAllow);
}
}else{ }else{
decisionHandler(WKNavigationActionPolicyCancel); decisionHandler(WKNavigationActionPolicyCancel);
} }