From f42226dddb1b05cdbbf094185dfcd2658ec7254b Mon Sep 17 00:00:00 2001 From: jakub-g Date: Wed, 18 May 2016 15:55:27 +0200 Subject: [PATCH] doc: do not use `with` in JS samples The usage of `with` JS statement is highly discouraged for a number of reasons, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with http://www.2ality.com/2011/06/with-statement.html --- README.md | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 1440308..a1a516f 100644 --- a/README.md +++ b/README.md @@ -235,14 +235,11 @@ function showHelp(url) { inAppBrowserRef = cordova.InAppBrowser.open(url, target, options); - with (inAppBrowserRef) { + inAppBrowserRef.addEventListener('loadstart', loadStartCallBack); - addEventListener('loadstart', loadStartCallBack); + inAppBrowserRef.addEventListener('loadstop', loadStopCallBack); - addEventListener('loadstop', loadStopCallBack); - - addEventListener('loaderror', loadErrorCallBack); - } + inAppBrowserRef.addEventListener('loaderror', loadErrorCallBack); } @@ -544,14 +541,11 @@ function showHelp(url) { inAppBrowserRef = cordova.InAppBrowser.open(url, target, options); - with (inAppBrowserRef) { + inAppBrowserRef.addEventListener('loadstart', loadStartCallBack); - addEventListener('loadstart', loadStartCallBack); + inAppBrowserRef.addEventListener('loadstop', loadStopCallBack); - addEventListener('loadstop', loadStopCallBack); - - addEventListener('loaderror', loadErrorCallBack); - } + inAppBrowserRef.addEventListener('loaderror', loadErrorCallBack); }