chore(): update changelog

CHANGELOG.md

@@ -1,3 +1,50 @@
+<a name="2.1.7"></a>
+## [2.1.7](https://github.com/driftyco/ionic-native/compare/v2.1.6...v2.1.7) (2016-10-07)
+
+
+### Bug Fixes
+
+* **paypal:** fixed currency code not found issue ([#653](https://github.com/driftyco/ionic-native/issues/653)) ([598f8a9](https://github.com/driftyco/ionic-native/commit/598f8a9))
+
+
+
+<a name="2.1.6"></a>
+## [2.1.6](https://github.com/driftyco/ionic-native/compare/v2.1.5...v2.1.6) (2016-10-06)
+
+
+### Bug Fixes
+
+* **paypal:** fix helper classes ([f002657](https://github.com/driftyco/ionic-native/commit/f002657))
+
+
+
+<a name="2.1.5"></a>
+## [2.1.5](https://github.com/driftyco/ionic-native/compare/v2.1.4...v2.1.5) (2016-10-06)
+
+
+
+<a name="2.1.4"></a>
+## [2.1.4](https://github.com/driftyco/ionic-native/compare/v2.1.3...v2.1.4) (2016-10-06)
+
+
+### Bug Fixes
+
+* **google-analytics:** specify successIndex and errorIndex for methods with optional params ([6f23bef](https://github.com/driftyco/ionic-native/commit/6f23bef))
+
+
+
+<a name="2.1.3"></a>
+## [2.1.3](https://github.com/driftyco/ionic-native/compare/v2.1.2...v2.1.3) (2016-10-06)
+
+
+### Bug Fixes
+
+* **google-analytics:** add missing methods, fix return types ([77b0277](https://github.com/driftyco/ionic-native/commit/77b0277))
+* **google-analytics:** add newSession param ([f62e108](https://github.com/driftyco/ionic-native/commit/f62e108))
+* **google-analytics:** fix depreciated plugin reference ([40325ca](https://github.com/driftyco/ionic-native/commit/40325ca))
+
+
+
 <a name="2.1.2"></a>
 ## [2.1.2](https://github.com/driftyco/ionic-native/compare/v2.1.1...v2.1.2) (2016-10-06)
 

gulpfile.js

@@ -2,7 +2,7 @@ var gulp = require('gulp');
 var minimist = require('minimist');
 var uglify = require('gulp-uglify');
 var rename = require("gulp-rename");
-var tslint = require('ionic-gulp-tslint');
+var tslint = require('gulp-tslint');
 var decamelize = require('decamelize');
 var replace = require('gulp-replace');
 
@@ -28,7 +28,12 @@ gulp.task("minify:dist", function(){
 });
 
 gulp.task('lint', function() {
-  tslint({src: 'src/**/*.ts'});
+  gulp.src('src/**/*.ts')
+    .pipe(tslint({
+      formatter: "verbose",
+      configuration: 'tslint.json'
+    }))
+    .pipe(tslint.report())
 });
 
 gulp.task('plugin:create', function(){

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ionic-native",
-  "version": "2.1.2",
+  "version": "2.1.7",
   "description": "Native plugin wrappers for Cordova and Ionic with TypeScript, ES6+, Promise and Observable support",
   "main": "dist/es5/index.js",
   "module": "dist/esm/index.js",
@@ -26,9 +26,8 @@
     "gulp": "^3.9.1",
     "gulp-rename": "^1.2.2",
     "gulp-replace": "^0.5.4",
-    "gulp-tslint": "^5.0.0",
+    "gulp-tslint": "^6.1.2",
     "gulp-uglify": "^1.5.4",
-    "ionic-gulp-tslint": "^1.0.0",
     "jasmine-core": "~2.5.0",
     "karma": "~1.2.0",
     "karma-browserify": "~5.1.0",
@@ -41,7 +40,7 @@
     "q": "1.4.1",
     "semver": "^5.0.1",
     "tsify": "~1.0.4",
-    "tslint": "^3.8.1",
+    "tslint": "^3.15.1",
     "tslint-ionic-rules": "0.0.5",
     "typescript": "^2.0.1",
     "watchify": "~3.7.0"

src/plugins/googleanalytics.ts

@@ -14,7 +14,7 @@ declare var window;
  */
 @Plugin({
   plugin: 'cordova-plugin-google-analytics',
-  pluginRef: 'analytics',
+  pluginRef: 'ga',
   repo: 'https://github.com/danwilson/google-analytics-plugin',
   platforms: ['Android', 'iOS']
 })
@@ -23,45 +23,128 @@ export class GoogleAnalytics {
    * In your 'deviceready' handler, set up your Analytics tracker.
    * https://developers.google.com/analytics/devguides/collection/analyticsjs/
    * @param {string}  id  Your Google Analytics Mobile App property
+   * @return {Promise<any>}
    */
   @Cordova()
   static startTrackerWithId(id: string): Promise<any> { return; }
 
+  /**
+   * Enabling Advertising Features in Google Analytics allows you to take advantage of Remarketing, Demographics & Interests reports, and more
+   * @param allow {boolean}
+   * @return {Promise<any>}
+   */
+  @Cordova()
+  static setAllowIDFACollection(allow: boolean): Promise<any> { return; }
+
+  /**
+   * Set a UserId
+   * https://developers.google.com/analytics/devguides/collection/analyticsjs/user-id
+   * @param {string} id User ID
+   * @return {Promise<any>}
+   */
+  @Cordova()
+  static setUserId(id: string): Promise<any> { return; }
+
+  /**
+   * Set a anonymize Ip address
+   * @param anonymize {boolean} Set to true to anonymize the IP Address
+   * @return {Promise<any>}
+   */
+  @Cordova()
+  static setAnonymizeIp(anonymize: boolean): Promise<any> { return; }
+
+  /**
+   * Sets the app version
+   * @param appVersion {string} App version
+   * @return {Promise<any>}
+   */
+  @Cordova()
+  static setAppVersion(appVersion: string): Promise<any> { return; }
+
+  /**
+   * Set OptOut
+   * @param optout {boolean}
+   * @return {Promise<any>}
+   */
+  @Cordova()
+  static setOptOut(optout: boolean): Promise<any> { return; }
+
+  /**
+   * Enable verbose logging
+   * @return {Promise<any>}
+   */
+  @Cordova()
+  static debugMode(): Promise<any> { return; }
+
+  /**
+   * Track custom metric
+   * @param key {string}
+   * @param value {any}
+   * @return {Promise<any>}
+   */
+  @Cordova({
+    successIndex: 2,
+    errorIndex: 3
+  })
+  static trackMetric(key: string, value?: any): Promise<any> { return; }
+
   /**
    * Track a screen
    * https://developers.google.com/analytics/devguides/collection/analyticsjs/screens
    *
-   * @param {string}  title         Screen title
-   * @param {string}  campaignUrl   Campaign url for measuring referrals
+   * @param title {string} Screen title
+   * @param campaignUrl {string} Campaign url for measuring referrals
+   * @param newSession {boolean} Set to true to create a new session
+   * @return {Promise<any>}
+   */
+  @Cordova({
+    successIndex: 3,
+    errorIndex: 4
+  })
+  static trackView(title: string, campaignUrl?: string, newSession?: boolean): Promise<any> { return; }
+
+  /**
+   * Add a Custom Dimension
+   * https://developers.google.com/analytics/devguides/platform/customdimsmets
+   * @param key {string}
+   * @param value {string}
+   * @return {Promise<any>}
    */
   @Cordova()
-  static trackView(title: string, campaignUrl?: string): Promise<any> { return; }
+  static addCustomDimension(key: number, value: string): Promise<any> { return; }
 
   /**
    * Track an event
    * https://developers.google.com/analytics/devguides/collection/analyticsjs/events
-   * @param {string}  category
-   * @param {string}  action
-   * @param {string}  label
-   * @param {number}  value
+   * @param category {string}
+   * @param action {string}
+   * @param label {string}
+   * @param value {number}
+   * @param newSession {boolean} Set to true to create a new session
+   * @return {Promise<any>}
    */
-  @Cordova()
-  static trackEvent(category: string, action: string, label?: string, value?: number): Promise<any> { return; }
+  @Cordova({
+    successIndex: 5,
+    errorIndex: 6
+  })
+  static trackEvent(category: string, action: string, label?: string, value?: number, newSession?: boolean): Promise<any> { return; }
 
   /**
    * Track an exception
-   * @param {string}  description
-   * @param {boolean} fatal
+   * @param description {string}
+   * @param fatal {boolean}
+   * @return {Promise<any>}
    */
   @Cordova()
   static trackException(description: string, fatal: boolean): Promise<any> { return; }
 
   /**
    * Track User Timing (App Speed)
-   * @param {string}  category
-   * @param {number}  intervalInMilliseconds
-   * @param {string}  variable
-   * @param {string}  label
+   * @param category {string}
+   * @param intervalInMilliseconds {number}
+   * @param variable {string}
+   * @param label {string}
+   * @return {Promise<any>}
    */
   @Cordova()
   static trackTiming(category: string, intervalInMilliseconds: number, variable: string, label: string): Promise<any> { return; }
@@ -69,12 +152,13 @@ export class GoogleAnalytics {
   /**
    * Add a Transaction (Ecommerce)
    * https://developers.google.com/analytics/devguides/collection/analyticsjs/ecommerce#addTrans
-   * @param {string}  id
-   * @param {string}  affiliation
-   * @param {number}  revenue
-   * @param {number}  tax
-   * @param {number}  shipping
-   * @param {string}  currencyCode
+   * @param id {string}
+   * @param affiliation {string}
+   * @param revenue {number}
+   * @param tax {number}
+   * @param shipping {number}
+   * @param currencyCode {string}
+   * @return {Promise<any>}
    */
   @Cordova()
   static addTransaction(id: string, affiliation: string, revenue: number, tax: number, shipping: number, currencyCode: string): Promise<any> { return; }
@@ -89,57 +173,15 @@ export class GoogleAnalytics {
    * @param {number}  price
    * @param {number}  quantity
    * @param {string}  currencyCode
+   * @return {Promise<any>}
    */
   @Cordova()
   static addTransactionItem(id: string, name: string, sku: string, category: string, price: number, quantity: number, currencyCode: string): Promise<any> { return; }
 
-  /**
-   * Add a Custom Dimension
-   * https://developers.google.com/analytics/devguides/platform/customdimsmets
-   * @param {string}  key
-   * @param {string}  value
-   */
-  @Cordova()
-  static addCustomDimension(key: number, value: string): Promise<any> { return; }
-
-  /**
-   * Set a UserId
-   * https://developers.google.com/analytics/devguides/collection/analyticsjs/user-id
-   * @param {string}  id
-   */
-  @Cordova({sync: true})
-  static setUserId(id: string): void { }
-
-  /**
-   * Sets the app version
-   * @param appVersion
-   */
-  @Cordova({sync: true})
-  static setAppVersion(appVersion: string): void { }
-
-  /**
-   * Set a anonymize Ip address
-   * @param anonymize
-   */
-  @Cordova({sync: true})
-  static setAnonymizeIp(anonymize: boolean): void { }
-
-  /**
-   * Enabling Advertising Features in Google Analytics allows you to take advantage of Remarketing, Demographics & Interests reports, and more
-   * @param allow
-   */
-  @Cordova({sync: true})
-  static setAllowIDFACollection(allow: boolean): void { }
-
-  /**
-   * Enable verbose logging
-   */
-  @Cordova({sync: true})
-  static debugMode(): Promise<any> { return; }
-
   /**
    * Enable/disable automatic reporting of uncaught exceptions
-   * @param {boolean} shouldEnable
+   * @param shouldEnable {boolean}
+   * @return {Promise<any>}
    */
   @Cordova()
   static enableUncaughtExceptionReporting(shouldEnable: boolean): Promise<any> { return; }

src/plugins/hotspot.ts

@@ -217,27 +217,27 @@ export class Hotspot {
 
 export interface ConnectionInfo {
   /**
-   * @property {string}   SSID
+   *   SSID
    *      The service set identifier (SSID) of the current 802.11 network.
    */
   SSID: string;
   /**
-   * @property {string}   BSSID
+   *   BSSID
    *      The basic service set identifier (BSSID) of the current access point.
    */
   BSSID: string;
   /**
-   * @property {string}   linkSpeed
+   *   linkSpeed
    *      The current link speed in Mbps
    */
   linkSpeed: string;
   /**
-   * @property {string}   IPAddress
+   *   IPAddress
    *      The IP Address
    */
   IPAddress: string;
   /**
-   * @property {string}   networkID
+   *   networkID
    *      Each configured network has a unique small integer ID, used to identify the network when performing operations on the supplicant.
    */
   networkID: string;
@@ -245,62 +245,62 @@ export interface ConnectionInfo {
 
 export interface HotspotNetwork {
   /**
-   * @property {string}       SSID
+   *       SSID
    *      Human readable network name
    */
   SSID: string;
   /**
-   * @property {string}       BSSID
+   *       BSSID
    *      MAC Address of the access point
    */
   BSSID: string;
   /**
-   * @property {number (int)} frequency
+   * frequency
    *      The primary 20 MHz frequency (in MHz) of the channel over which the client is communicating with the access point.
    */
   frequency: number;
   /**
-   * @property {number}       level
+   *       level
    *      The detected signal level in dBm, also known as the RSSI.
    */
   level: number;
   /**
-   * @property {number}       timestamp
+   *       timestamp
    *      Timestamp in microseconds (since boot) when this result was last seen.
    */
   timestamp: number;
   /**
-   * @property {string}       capabilities
+   *       capabilities
    *      Describes the authentication, key management, and encryption schemes supported by the access point.
    */
   capabilities: string;
 }
 export interface HotspotNetworkConfig {
   /**
-   * @property {string}   deviceIPAddress - Device IP Address
+   *   deviceIPAddress - Device IP Address
    */
   deviceIPAddress: string;
   /**
-   * @property {string}   deviceMacAddress - Device MAC Address
+   *   deviceMacAddress - Device MAC Address
    */
   deviceMacAddress: string;
   /**
-   * @property {string}   gatewayIPAddress - Gateway IP Address
+   *   gatewayIPAddress - Gateway IP Address
    */
   gatewayIPAddress: string;
   /**
-   * @property {string}   gatewayMacAddress - Gateway MAC Address
+   *   gatewayMacAddress - Gateway MAC Address
    */
   gatewayMacAddress: string;
 }
 export interface HotspotDevice {
   /**
-   * @property {string}   ip
+   *   ip
    *      Hotspot IP Address
    */
   ip: string;
   /**
-   * @property {string}   mac
+   *   mac
    *      Hotspot MAC Address
    */
   mac: string;

src/plugins/pay-pal.ts

@@ -18,10 +18,11 @@ import { Plugin, Cordova } from './plugin';
  * ```
  * @interfaces
  * PayPalEnvironment
+ * PayPalConfigurationOptions
+ * @classes
  * PayPalPayment
  * PayPalItem
  * PayPalPaymentDetails
- * PayPalConfigurationOptions
  * PayPalShippingAddress
  */
 @Plugin({
@@ -91,21 +92,26 @@ export interface PayPalEnvironment {
   PayPalEnvironmentProduction: string;
   PayPalEnvironmentSandbox: string;
 }
-export declare var PayPalPayment: {
+
+/**
+ * @private
+ */
+export class PayPalPayment {
   /**
    * Convenience constructor.
    * Returns a PayPalPayment with the specified amount, currency code, and short description.
    * @param {String} amount: The amount of the payment.
-   * @param {String} currencyCode: The ISO 4217 currency for the payment.
+   * @param {String} currency: The ISO 4217 currency for the payment.
    * @param {String} shortDescription: A short description of the payment.
    * @param {String} intent: "Sale" for an immediate payment.
    */
-  new(amount: string, currencyCode: string, shortDescription: string, intent: string): PayPalPayment;
-};
-/**
- * @private
- */
-export interface PayPalPayment {
+  constructor(amount: string, currency: string, shortDescription: string, intent: string) {
+    this.amount = amount;
+    this.currency = currency;
+    this.shortDescription = shortDescription;
+    this.intent = intent;
+  }
+
   /**
    * The amount of the payment.
    */
@@ -113,7 +119,7 @@ export interface PayPalPayment {
   /**
    * The ISO 4217 currency for the payment.
    */
-  currencyCode: string;
+  currency: string;
   /**
    * A short description of the payment.
    */
@@ -126,7 +132,7 @@ export interface PayPalPayment {
    * Optional Build Notation code ("BN code"), obtained from partnerprogram@paypal.com,
    * for your tracking purposes.
    */
-  bnCode: string;
+  bnCode: string = 'PhoneGap_SP';
   /**
    * Optional invoice number, for your tracking purposes. (up to 256 characters)
    */
@@ -153,7 +159,27 @@ export interface PayPalPayment {
   shippingAddress: string;
 }
 
-export interface PayPalItem {
+/**
+ * @private
+ */
+export class PayPalItem {
+  /**
+   * The PayPalItem class defines an optional itemization for a payment.
+   * @see https://developer.paypal.com/docs/api/#item-object for more details.
+   * @param {String} name: Name of the item. 127 characters max
+   * @param {Number} quantity: Number of units. 10 characters max.
+   * @param {String} price: Unit price for this item 10 characters max.
+   * May be negative for "coupon" etc
+   * @param {String} currency: ISO standard currency code.
+   * @param {String} sku: The stock keeping unit for this item. 50 characters max (optional)
+   */
+  constructor(name: string, quantity: number, price: string, currency: string, sku: string) {
+    this.name = name;
+    this.quantity = quantity;
+    this.price = price;
+    this.currency = currency;
+    this.sku = sku;
+  }
   /**
    * Name of the item. 127 characters max
    */
@@ -176,21 +202,21 @@ export interface PayPalItem {
   sku: string;
 }
 
-export declare var PayPalItem: {
+/**
+ * @private
+ */
+export class PayPalPaymentDetails {
   /**
-   * The PayPalItem class defines an optional itemization for a payment.
-   * @see https://developer.paypal.com/docs/api/#item-object for more details.
-   * @param {String} name: Name of the item. 127 characters max
-   * @param {Number} quantity: Number of units. 10 characters max.
-   * @param {String} price: Unit price for this item 10 characters max.
-   * May be negative for "coupon" etc
-   * @param {String} currency: ISO standard currency code.
-   * @param {String} sku: The stock keeping unit for this item. 50 characters max (optional)
+   * The PayPalPaymentDetails class defines optional amount details.
+   * @param {String} subtotal: Sub-total (amount) of items being paid for. 10 characters max with support for 2 decimal places.
+   * @param {String} shipping: Amount charged for shipping. 10 characters max with support for 2 decimal places.
+   * @param {String} tax: Amount charged for tax. 10 characters max with support for 2 decimal places.
    */
-  new(name: string, quantity: number, price: string, currency: string, sku: string): PayPalItem;
-};
-
-export interface PayPalPaymentDetails {
+  constructor(subtotal: string, shipping: string, tax: string) {
+    this.subtotal = subtotal;
+    this.shipping = shipping;
+    this.tax = tax;
+  }
   /**
    * Sub-total (amount) of items being paid for. 10 characters max with support for 2 decimal places.
    */
@@ -205,16 +231,6 @@ export interface PayPalPaymentDetails {
   tax: string;
 }
 
-export declare var PayPalPaymentDetails: {
-  /**
-   * The PayPalPaymentDetails class defines optional amount details.
-   * @param {String} subtotal: Sub-total (amount) of items being paid for. 10 characters max with support for 2 decimal places.
-   * @param {String} shipping: Amount charged for shipping. 10 characters max with support for 2 decimal places.
-   * @param {String} tax: Amount charged for tax. 10 characters max with support for 2 decimal places.
-   */
-  new(subtotal: string, shipping: string, tax: string): PayPalPaymentDetails;
-};
-
 /**
  * @private
  */
@@ -238,11 +254,11 @@ export interface PayPalConfigurationOptions {
   /**
    * URL of your company's privacy policy, which will be offered to the user when requesting consent via a PayPalFuturePaymentViewController.
    */
-  merchantPrivacyPolicyUrl?: string;
+  merchantPrivacyPolicyURL?: string;
   /**
    * URL of your company's user agreement, which will be offered to the user when requesting consent via a PayPalFuturePaymentViewController.
    */
-  merchantUserAgreementUrl?: string;
+  merchantUserAgreementURL?: string;
   /**
    * If set to NO, the SDK will only support paying with PayPal, not with credit cards.
    * This applies only to single payments (via PayPalPaymentViewController).
@@ -316,35 +332,47 @@ export interface PayPalConfigurationOptions {
 /**
  * @private
  */
-export declare var PayPalConfiguration: {
+export class PayPalConfiguration implements PayPalConfigurationOptions {
   /**
    * You use a PayPalConfiguration object to configure many aspects of how the SDK behaves.
    * see defaults for options available
    */
-  new(options: PayPalConfigurationOptions): PayPalConfiguration;
-};
+  constructor(options?: PayPalConfigurationOptions) {
 
-export interface PayPalConfiguration {
-  defaultUserEmail: string;
-  defaultUserPhoneCountryCode: string;
-  defaultUserPhoneNumber: string;
-  merchantName: string;
-  merchantPrivacyPolicyUrl: string;
-  merchantUserAgreementUrl: string;
-  acceptCreditCards: boolean;
-  payPalShippingAddressOption: number;
-  rememberUser: boolean;
-  languageOrLocale: string;
-  disableBlurWhenBackgrounding: boolean;
-  presentingInPopover: boolean;
-  forceDefaultsInSandbox: boolean;
-  sandboxUserPassword: string;
-  sandboxUserPin: string;
+    let defaults: PayPalConfigurationOptions = {
+      defaultUserEmail: null,
+      defaultUserPhoneCountryCode: null,
+      defaultUserPhoneNumber: null,
+      merchantName: null,
+      merchantPrivacyPolicyURL: null,
+      merchantUserAgreementURL: null,
+      acceptCreditCards: true,
+      payPalShippingAddressOption: 0,
+      rememberUser: true,
+      languageOrLocale: null,
+      disableBlurWhenBackgrounding: false,
+      presentingInPopover: false,
+      forceDefaultsInSandbox: false,
+      sandboxUserPassword: null,
+      sandboxUserPin: null
+    };
+
+    if (options && typeof options === 'object') {
+      for (var i in options) {
+        if (defaults.hasOwnProperty(i)) {
+          defaults[i] = options[i];
+        }
+      }
+    }
+
+    return defaults;
+  }
 }
+
 /**
  * @private
  */
-export declare var PayPalShippingAddress: {
+export class PayPalShippingAddress {
   /**
    * See the documentation of the individual properties for more detail.
    * @param {String} recipientName: Name of the recipient at this address. 50 characters max.
@@ -355,10 +383,15 @@ export declare var PayPalShippingAddress: {
    * @param {String} postalCode: ZIP code or equivalent is usually required for countries that have them. 20 characters max. Required in certain countries.
    * @param {String} countryCode: 2-letter country code. 2 characters max.
    */
-  new(recipientName: string, line1: string, line2: string, city: string, state: string, postalCode: string, countryCode: string): PayPalShippingAddress;
-};
-
-export interface PayPalShippingAddress {
+  constructor(recipientName: string, line1: string, line2: string, city: string, state: string, postalCode: string, countryCode: string) {
+    this.recipientName = recipientName;
+    this.line1 = line1;
+    this.line2 = line2;
+    this.city = city;
+    this.state = state;
+    this.postalCode = postalCode;
+    this.countryCode = countryCode;
+  }
   /**
    * Name of the recipient at this address. 50 characters max.
    */

src/plugins/plugin.ts

@@ -61,7 +61,12 @@ function setIndex(args: any[], opts: any = {}, resolve?: Function, reject?: Func
     args.push(obj);
   } else if (typeof opts.successIndex !== 'undefined' || typeof opts.errorIndex !== 'undefined') {
     // If we've specified a success/error index
-    args.splice(opts.successIndex, 0, resolve);
+
+    if (opts.successIndex > args.length) {
+      args[opts.successIndex] = resolve;
+    } else {
+      args.splice(opts.successIndex, 0, resolve);
+    }
 
     // We don't want that the reject cb gets spliced into the position of an optional argument that has not been defined and thus causing non expected behaviour.
     if (opts.errorIndex > args.length) {
@@ -72,8 +77,10 @@ function setIndex(args: any[], opts: any = {}, resolve?: Function, reject?: Func
   } else {
     // Otherwise, let's tack them on to the end of the argument list
     // which is 90% of cases
-    args.push(resolve);
-    args.push(reject);
+    if (!opts.sync) {
+      args.push(resolve);
+      args.push(reject);
+    }
   }
   return args;
 }

test/plugin.spec.ts

@@ -36,7 +36,7 @@ describe('plugin', () => {
     const spy = spyOn(window.plugins.test, 'syncMethod').and.callThrough();
     const result = Test.syncMethod('foo');
     expect(result).toEqual('syncResult');
-    expect(spy).toHaveBeenCalledWith('foo', undefined, undefined);
+    expect(spy).toHaveBeenCalledWith('foo');
 
   });
 
@@ -138,4 +138,4 @@ describe('plugin', () => {
 
   });
 
-});
+});