chore(): update changelog

I added a change that makes it clear that the map element needs a height to be visible.

I tried to follow the docs but It didn't work, after that I thought my API keys were invalid, at the end it turned out the map wasn't visible at all.

CHANGELOG.md

@@ -1,3 +1,57 @@
+<a name="2.2.17"></a>
+## [2.2.17](https://github.com/driftyco/ionic-native/compare/v2.2.16...v2.2.17) (2017-01-20)
+
+
+### Bug Fixes
+
+* **app-rate:** onRateDialogShow callback ([#985](https://github.com/driftyco/ionic-native/issues/985)) ([ab681cc](https://github.com/driftyco/ionic-native/commit/ab681cc))
+* **core:** increase deviceready timeout for sanity ([0ab14a0](https://github.com/driftyco/ionic-native/commit/0ab14a0))
+
+
+### Features
+
+* **barcodescanner:** add missing options ([#966](https://github.com/driftyco/ionic-native/issues/966)) ([e902856](https://github.com/driftyco/ionic-native/commit/e902856)), closes [#965](https://github.com/driftyco/ionic-native/issues/965)
+
+
+
+<a name="2.2.16"></a>
+## [2.2.16](https://github.com/driftyco/ionic-native/compare/v2.2.15...v2.2.16) (2017-01-11)
+
+
+
+<a name="2.2.15"></a>
+## [2.2.15](https://github.com/driftyco/ionic-native/compare/v2.2.14...v2.2.15) (2017-01-11)
+
+
+### Bug Fixes
+
+* **apprate:** captialize URL in storeAppURL property ([b98fa28](https://github.com/driftyco/ionic-native/commit/b98fa28))
+* **ble:** stopScan takes no args when used as clear function ([#944](https://github.com/driftyco/ionic-native/issues/944)) ([6ddd2aa](https://github.com/driftyco/ionic-native/commit/6ddd2aa))
+* **onesignal:** OSNotification.app_id is optional ([#946](https://github.com/driftyco/ionic-native/issues/946)) ([ebf0716](https://github.com/driftyco/ionic-native/commit/ebf0716))
+
+
+
+<a name="2.2.14"></a>
+## [2.2.14](https://github.com/driftyco/ionic-native/compare/v2.2.13...v2.2.14) (2017-01-07)
+
+
+### Bug Fixes
+
+* **google-analytics:** fix startTrackerWithId when interval is not provided ([49fe24d](https://github.com/driftyco/ionic-native/commit/49fe24d))
+* **google-plus:** fixes login without options ([ca14bf6](https://github.com/driftyco/ionic-native/commit/ca14bf6)), closes [#932](https://github.com/driftyco/ionic-native/issues/932)
+* **inappbrowser:** fix insertCSS method name ([de07df6](https://github.com/driftyco/ionic-native/commit/de07df6)), closes [#921](https://github.com/driftyco/ionic-native/issues/921)
+* **mixpanel:** fix issue when not passing eventProperties ([#927](https://github.com/driftyco/ionic-native/issues/927)) ([bbf75bc](https://github.com/driftyco/ionic-native/commit/bbf75bc))
+* **nfc:** add missing param for addMimeTypeListener ([#937](https://github.com/driftyco/ionic-native/issues/937)) ([ca60c5b](https://github.com/driftyco/ionic-native/commit/ca60c5b))
+* **push:** fix typing for additionalData ([0d6997c](https://github.com/driftyco/ionic-native/commit/0d6997c)), closes [#868](https://github.com/driftyco/ionic-native/issues/868)
+
+
+### Features
+
+* **background-geolocation:** add altitudeAccuracy into response typings ([#922](https://github.com/driftyco/ionic-native/issues/922)) ([8eb656c](https://github.com/driftyco/ionic-native/commit/8eb656c))
+* **market:** add search method, return promises ([d62779a](https://github.com/driftyco/ionic-native/commit/d62779a))
+
+
+
 <a name="2.2.13"></a>
 ## [2.2.13](https://github.com/driftyco/ionic-native/compare/v2.2.12...v2.2.13) (2016-12-27)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ionic-native",
-  "version": "2.2.13",
+  "version": "2.2.17",
   "description": "Native plugin wrappers for Cordova and Ionic with TypeScript, ES6+, Promise and Observable support",
   "main": "dist/es5/index.js",
   "module": "dist/esm/index.js",
@@ -9,40 +9,40 @@
     "dist"
   ],
   "dependencies": {
-    "rxjs": "^5.0.0-beta.6"
+    "rxjs": "5.0.0-beta.12"
   },
   "devDependencies": {
-    "browserify": "^13.0.1",
+    "browserify": "^13.3.0",
     "canonical-path": "0.0.2",
     "conventional-changelog-cli": "^1.2.0",
     "conventional-github-releaser": "^1.1.3",
-    "cpr": "^1.0.0",
-    "cz-conventional-changelog": "^1.1.6",
+    "cpr": "^2.0.2",
+    "cz-conventional-changelog": "^1.2.0",
     "decamelize": "^1.2.0",
     "dgeni": "^0.4.2",
     "dgeni-packages": "^0.10.18",
-    "es6-shim": "~0.35.1",
-    "glob": "^6.0.4",
+    "es6-shim": "~0.35.2",
+    "glob": "^7.1.1",
     "gulp": "^3.9.1",
     "gulp-rename": "^1.2.2",
     "gulp-replace": "^0.5.4",
     "gulp-tslint": "^6.1.2",
-    "gulp-uglify": "^1.5.4",
-    "jasmine-core": "~2.5.0",
-    "karma": "~1.2.0",
+    "gulp-uglify": "^2.0.0",
+    "jasmine-core": "~2.5.2",
+    "karma": "~1.3.0",
     "karma-browserify": "~5.1.0",
-    "karma-jasmine": "~1.0.2",
+    "karma-jasmine": "~1.1.0",
     "karma-phantomjs-launcher": "~1.0.2",
-    "lodash": "3.10.1",
+    "lodash": "4.17.4",
     "minimist": "^1.1.3",
     "mkdirp": "^0.5.1",
     "node-html-encoder": "0.0.2",
     "q": "1.4.1",
-    "semver": "^5.0.1",
-    "tsify": "~1.0.4",
+    "semver": "^5.3.0",
+    "tsify": "~3.0.0",
     "tslint": "^3.15.1",
-    "tslint-ionic-rules": "0.0.5",
-    "typescript": "^2.0.1",
+    "tslint-ionic-rules": "0.0.7",
+    "typescript": "~2.0.10",
     "watchify": "~3.7.0"
   },
   "scripts": {
@@ -50,7 +50,6 @@
     "test:watch": "npm test -- --watch",
     "start": "npm run test:watch",
     "lint": "gulp lint",
-    "watch": "tsc -w",
     "build": "npm run lint && npm run build:js && npm run build:esm && npm run build:bundle && npm run build:minify",
     "build:js": "tsc -p tsconfig-es5.json",
     "build:esm": "tsc -p tsconfig-esm.json",

scripts/docs/dgeni-config.js

@@ -76,7 +76,7 @@ module.exports = function(currentVersion) {
 
   versions = [];
   // new version, add it to the versions list
-  if (currentVersion != 'nightly' && !_.contains(versions, currentVersion)) {
+  if (currentVersion != 'nightly' && !_.includes(versions, currentVersion)) {
     versions.unshift(currentVersion);
   }
   //First semver valid version is latest

scripts/docs/prepare.sh

@@ -30,7 +30,7 @@ function run {
     git pull origin master
   fi
 
-  git rm -rf content/docs/v2/native/*/
+  git rm -rf content/docs/v2/native/*/ || true
 
 }
 

scripts/docs/processors/collect-inputs-outputs.js

@@ -5,6 +5,15 @@ module.exports = function collectInputsOutputs() {
     $process: function(docs) {
       docs.forEach(function(doc) {
 
+        if (doc.statics && doc.statics.length) {
+          for (var i in doc.statics) {
+            // identify properties to differentiate from methods
+            if (typeof doc.statics[i].parameters == 'undefined') {
+              doc.statics[i].isProperty = true;
+            }
+          }
+        }
+
         if (doc.members && doc.members.length) {
           var members = [];
           var inputs = [];

scripts/docs/processors/jekyll.js

@@ -20,7 +20,9 @@ module.exports = function jekyll(renderDocsProcessor) {
         doc.outputPath = doc.outputPath.toLowerCase().replace(' ', '-');
         docs[i].URL = doc.outputPath.replace('docs/v2//', 'docs/v2/')
                                     .replace('/index.md', '')
-                                    .replace('content/','');
+                                    .replace('content/', '');
+
+        docs[i].demo = !!docs[i].demo;
       });
 
       docs.push({

scripts/docs/tag-defs/tag-defs.js

@@ -1,6 +1,10 @@
 module.exports = [
   {'name': 'advanced'},
   {'name': 'demo'},
+  {'name': 'beta', transforms: function(doc, tag, value) {
+    // make the value true or undefined instead of '' or undefined
+    return typeof value !== 'undefined';
+  }},
   {'name': 'usage'},
   {'name': 'classes'}, // related classes
   {'name': 'interfaces'} // related interfaces

scripts/docs/templates/common.template.html

@@ -200,7 +200,9 @@ docType: "<$ doc.docType $>"
     Delegate: <$ doc.delegate $>
   </small>
   <@ endif @>
-
+  <@- if doc.beta == true -@>
+    <span class="beta" title="beta">&beta;</span>
+  <@- endif -@>
 </h1>
 
 <a class="improve-v2-docs" href="http://github.com/driftyco/ionic-native/edit/master/<$ doc.fileInfo.relativePath|replace('/home/ubuntu/ionic-native/', '')|replace('//','/') $>#L<$ doc.location.start.line $>">
@@ -213,6 +215,15 @@ docType: "<$ doc.docType $>"
 <@- if doc.decorators @>
 
 <@ for prop in doc.decorators[0].argumentInfo @>
+
+<@ if doc.beta == true @>
+<p class="beta-notice">
+  This plugin is still in beta stage and may not work as expected. Please
+  submit any issues to the <a target="_blank"
+  href="<$ prop.repo $>/issues">plugin repo</a>.
+</p>
+<@ endif @>
+
 <pre><code>$ <@ if prop.install @><$ prop.install $><@ else @>ionic plugin add <$ prop.plugin $><@ endif -@></code></pre>
 <p>Repo:
   <a href="<$ prop.repo $>">
@@ -244,7 +255,7 @@ docType: "<$ doc.docType $>"
 <!-- @platforms tag end -->
 <@ endif @>
 <@ endfor @>
-<@ endif -@>
+<@ endif -@><!-- if doc.decorators -->
 
 <!-- @usage tag -->
 <@ if doc.usage @>

scripts/docs/templates/native_menu.template.html

@@ -1,4 +1,9 @@
-<@ for doc in docs @><@ if doc.URL and doc.private != true @>
+<@ for doc in docs @><@ if doc.URL and doc.private != true and doc.beta != true @>
 <li class="capitalize {% if page.id == '<$ doc.name|lower|replace(' ','-') $>' %}active{% endif %}">
   <a href="/<$ doc.URL $>"><$ doc.name $></a>
 </li><@ endif @><@ endfor @>
+
+<@ for doc in docs @><@ if doc.URL and doc.private != true and doc.beta == true @>
+<li class="capitalize {% if page.id == '<$ doc.name|lower|replace(' ','-') $>' %}active{% endif %}">
+  <a href="/<$ doc.URL $>"><$ doc.name $> <span class="beta">&beta;</span></a>
+</li><@ endif @><@ endfor @>

src/index.ts

@@ -1,6 +1,6 @@
 import { initAngular1 } from './ng1';
 
-const DEVICE_READY_TIMEOUT = 2000;
+const DEVICE_READY_TIMEOUT = 5000;
 
 declare var window;
 

src/plugins/appavailability.ts

@@ -16,7 +16,7 @@ import { Cordova, Plugin } from './plugin';
  *
  * if (Device.platform === 'iOS') {
  *   app = 'twitter://';
- * } else if (device.platform === 'Android') {
+ * } else if (Device.platform === 'Android') {
  *   app = 'com.twitter.android';
  * }
  *

src/plugins/apprate.ts

@@ -47,7 +47,7 @@ export interface AppRatePreferences {
   /**
    * App Store URLS
    */
-  storeAppUrl?: AppRateStoreAppUrls;
+  storeAppURL?: AppRateStoreAppUrls;
 
 }
 
@@ -61,7 +61,7 @@ export interface AppRateCallbacks {
   /**
    * call back function. called when rate-dialog showing
    */
-  onRateDialogShowed?: Function;
+  onRateDialogShow?: Function;
 
 }
 

src/plugins/background-geolocation.ts

@@ -49,6 +49,11 @@ export interface BackgroundGeolocationResponse {
    */
   altitude: number;
 
+  /**
+    * accuracy of the altitude if available.
+    */
+  altitudeAccuracy: number;
+
   /**
    * bearing, in degrees.
    */

src/plugins/barcodescanner.ts

@@ -37,6 +37,16 @@ export interface BarcodeScannerOptions {
    */
   orientation?: string;
 
+  /**
+   * Launch with the torch switched on (if available). Supported on Android only.
+   */
+  torchOn?: boolean;
+
+  /**
+   * Display scanned text for X ms. 0 suppresses it entirely, default 1500. Supported on Android only.
+   */
+  resultDisplayDuration?: number;
+
 }
 
 /**

src/plugins/ble.ts

@@ -205,7 +205,7 @@ export class BLE {
   @Cordova({
     observable: true,
     clearFunction: 'stopScan',
-    clearWithArgs: true
+    clearWithArgs: false
   })
   static startScan(services: string[]): Observable<any> { return; }
 
@@ -218,7 +218,7 @@ export class BLE {
   @Cordova({
     observable: true,
     clearFunction: 'stopScan',
-    clearWithArgs: true
+    clearWithArgs: false
   })
   static startScanWithOptions(services: string[], options: {reportDuplicates?: boolean} | any): Observable<any> { return; }
 

src/plugins/camera-preview.ts

@@ -22,6 +22,7 @@ export interface CameraPreviewSize {
 }
 
 /**
+ * @beta
  * @name CameraPreview
  * @description
  * Showing camera preview in HTML

src/plugins/emailcomposer.ts

@@ -24,6 +24,7 @@ export interface EmailComposerOptions {
 
 
 /**
+ * @beta
  * @name Email Composer
  * @description
  *

src/plugins/file-chooser.ts

@@ -11,8 +11,8 @@ import { Plugin, Cordova } from './plugin';
  * import {FileChooser} from 'ionic-native';
  *
  * FileChooser.open()
- *   .then(uri => console.log(uri);
- *   .catch(e => console.log(e);
+ *   .then(uri => console.log(uri));
+ *   .catch(e => console.log(e));
  *
  * ```
  */

src/plugins/file.ts

@@ -385,8 +385,8 @@ export class File {
   };
 
   /**
-   * Get free disk space
-   * @returns {Promise<number>} Returns a promise that resolves with the remaining free disk space
+   * Get free disk space in Bytes
+   * @returns {Promise<number>} Returns a promise that resolves with the remaining free disk space in Bytes
    */
   static getFreeDiskSpace(): Promise<number> {
     return new Promise<any>((resolve, reject) => {

src/plugins/globalization.ts

@@ -14,7 +14,8 @@ import { Cordova, Plugin } from './plugin';
   pluginName: 'Globalization',
   plugin: 'cordova-plugin-globalization',
   pluginRef: 'navigator.globalization',
-  repo: 'https://github.com/apache/cordova-plugin-globalization'
+  repo: 'https://github.com/apache/cordova-plugin-globalization',
+  platforms: ['Amazon Fire OS', 'Android', 'BlackBerry 10', 'Firefox OS', 'iOS', 'Windows Phone 8', 'Widnows', 'Browser']
 })
 export class Globalization {
 

src/plugins/google-plus.ts

@@ -7,6 +7,9 @@ import { Cordova, Plugin } from './plugin';
  * ```typescript
  * import { GooglePlus } from 'ionic-native';
  *
+ * GooglePlus.login()
+ *   .then(res => console.log(res))
+ *   .catch(err => console.error(err));
  *
  * ```
  */
@@ -25,7 +28,10 @@ export class GooglePlus {
    * @param options
    * @returns {Promise<any>}
    */
-  @Cordova()
+  @Cordova({
+    successIndex: 1,
+    errorIndex: 2
+  })
   static login(options?: any): Promise<any> { return; }
 
   /**

src/plugins/googleanalytics.ts

@@ -41,7 +41,10 @@ export class GoogleAnalytics {
    * @param {number} interval Optional dispatch period in seconds. Defaults to 30.
    * @returns {Promise<any>}
    */
-  @Cordova()
+  @Cordova({
+    successIndex: 2,
+    errorIndex: 3
+  })
   static startTrackerWithId(id: string, interval?: number): Promise<any> { return; }
 
   /**

src/plugins/googlemap.ts

@@ -60,8 +60,9 @@ export const GoogleMapsAnimation = {
  *
  * loadMap() {
  *  // make sure to create following structure in your view.html file
+ *  // and add a height (for example 100%) to it, else the map won't be visible
  *  // <ion-content>
- *  //  <div #map id="map"></div>
+ *  //  <div #map id="map" style="height:100%;"></div>
  *  // </ion-content>
  *
  *  // create a new map by passing HTMLElement

src/plugins/hotspot.ts

@@ -103,6 +103,7 @@ export interface HotspotDevice {
 }
 
 /**
+ * @beta
  * @name Hotspot
  * @description
  * @usage

src/plugins/ibeacon.ts

@@ -237,7 +237,7 @@ export interface IBeaconDelegate {
  * // Request permission to use location on iOS
  * IBeacon.requestAlwaysAuthorization();
  * // create a new delegate and register it with the native layer
- * let delegate = IBeacon.IBeaconDelegate();
+ * let delegate = IBeacon.Delegate();
  *
  * // Subscribe to some of the delegate's event handlers
  * delegate.didRangeBeaconsInRegion()

src/plugins/inappbrowser.ts

@@ -40,13 +40,6 @@ export interface InAppBrowserEvent extends Event {
 })
 export class InAppBrowser {
 
-  /**
-   * @private
-   */
-  static open(url: string, target?: string, options?: string): void {
-    console.warn('Native: Your current usage of the InAppBrowser plugin is deprecated as of ionic-native@1.3.8. Please check the Ionic Native docs for the latest usage details.');
-  }
-
   private _objectInstance: any;
 
   /**
@@ -81,7 +74,7 @@ export class InAppBrowser {
 
   /**
    * Injects JavaScript code into the InAppBrowser window.
-   * @param script    Details of the script to run, specifying either a file or code key.
+   * @param script {Object} Details of the script to run, specifying either a file or code key.
    * @returns {Promise<any>}
    */
   @CordovaInstance()
@@ -89,11 +82,11 @@ export class InAppBrowser {
 
   /**
    * Injects CSS into the InAppBrowser window.
-   * @param {Object}       Details of the script to run, specifying either a file or code key.
+   * @param css {Object} Details of the script to run, specifying either a file or code key.
    * @returns {Promise<any>}
    */
   @CordovaInstance()
-  insertCss(css: {file?: string, code?: string}): Promise<any> {return; }
+  insertCSS(css: {file?: string, code?: string}): Promise<any> {return; }
 
   /**
    * A method that allows you to listen to events happening in the browser.

src/plugins/market.ts

@@ -19,12 +19,30 @@ import { Plugin, Cordova } from './plugin';
   repo: 'https://github.com/xmartlabs/cordova-plugin-market'
 })
 export class Market {
+
   /**
    * Opens an app in Google Play / App Store
    * @param appId {string} Package name
-   * @param callbacks {Object} Optional callbacks in the format {success?: Function, failure?: Function}
+   * @return {Promise<any>}
    */
-  @Cordova({sync: true})
-  static open(appId: string, callbacks?: {success?: Function, failure?: Function}): void { }
+  @Cordova({
+    callbackStyle: 'object',
+    successName: 'success',
+    errorName: 'failure'
+  })
+  static open(appId: string): Promise<any> { return; }
+
+  /**
+   * Search apps by keyword
+   * @param keyword {string} Keyword
+   * @return {Promise<any>}
+   */
+  @Cordova({
+    callbackStyle: 'object',
+    successName: 'success',
+    errorName: 'failure',
+    platforms: ['Android']
+  })
+  static search(keyword: string): Promise<any> { return; }
 
 }

src/plugins/mixpanel.ts

@@ -85,7 +85,10 @@ export class Mixpanel {
    * @param eventProperties {any} optional
    * @returns {Promise<any>}
    */
-  @Cordova()
+  @Cordova({
+    successIndex: 2,
+    errorIndex: 3
+  })
   static track(eventName: string, eventProperties?: any): Promise<any> { return; }
 
   /**

src/plugins/network.ts

@@ -40,7 +40,7 @@ declare var navigator: any;
  *
  * ```
  * @advanced
- * The `connection` property will return one of the following connection types: `unknown`, `ethernet`, `wifi`, `2g`, `3g`, `4g`, `cellular`, `none`
+ * The `type` property will return one of the following connection types: `unknown`, `ethernet`, `wifi`, `2g`, `3g`, `4g`, `cellular`, `none`
  */
 @Plugin({
   pluginName: 'Network',

src/plugins/nfc.ts

@@ -62,18 +62,19 @@ export class NFC {
 
   /**
    * Registers an event listener for NDEF tags matching a specified MIME type.
+   * @param mimeType
    * @param onSuccess
    * @param onFailure
    * @returns {Observable<any>}
    */
   @Cordova({
     observable: true,
-    successIndex: 0,
-    errorIndex: 3,
+    successIndex: 1,
+    errorIndex: 4,
     clearFunction: 'removeMimeTypeListener',
     clearWithArgs: true
   })
-  static addMimeTypeListener(onSuccess?: Function, onFailure?: Function): Observable<any> {return; }
+  static addMimeTypeListener(mimeType: string, onSuccess?: Function, onFailure?: Function): Observable<any> {return; }
 
   /**
    * Registers an event listener for formatable NDEF tags.
@@ -161,7 +162,7 @@ export class NFC {
   /**
    * Convert string to bytes
    * @param str {string}
-   * @returns {string}
+   * @returns {number[]}
    */
   @Cordova({ sync: true })
   static stringToBytes(str: string): number[] {return; };

src/plugins/onesignal.ts

@@ -26,7 +26,7 @@ export interface OSNotification {
    * **ANDROID** - Notification is a summary notification for a group this will contain all notification payloads it was created from.
    */
   groupedNotifications?: OSNotificationPayload[];
-  app_id: string;
+  app_id?: string;
   contents: any;
   headings?: any;
   isIos?: boolean;
@@ -382,7 +382,7 @@ export class OneSignal {
    * Lets you retrieve the OneSignal user id and device token.
    * Your handler is called after the device is successfully registered with OneSignal.
    *
-   * @returns {Promise<{userId: string; pushToken: string}>} Returns a Promise that reolves if the device was successfully registered.
+   * @returns {Promise<Object>} Returns a Promise that resolves if the device was successfully registered.
    *
    *  userId {string} OneSignal userId is a UUID formatted string. (unique per device per app)
    *

src/plugins/plugin.ts

@@ -108,7 +108,7 @@ function callCordovaPlugin(pluginObj: any, methodName: string, args: any[], opts
 
   let pluginInstance = getPlugin(pluginObj.pluginRef);
 
-  if (!pluginInstance) {
+  if (!pluginInstance || pluginInstance[methodName] === 'undefined') {
     // Do this check in here in the case that the Web API for this plugin is available (for example, Geolocation).
     if (!window.cordova) {
       cordovaWarn(pluginObj.pluginName, methodName);
@@ -123,8 +123,7 @@ function callCordovaPlugin(pluginObj: any, methodName: string, args: any[], opts
     };
   }
 
-  // TODO: Illegal invocation needs window context
-  return get(window, pluginObj.pluginRef)[methodName].apply(pluginInstance, args);
+  return pluginInstance[methodName].apply(pluginInstance, args);
 }
 
 /**
@@ -408,9 +407,9 @@ export function CordovaInstance(opts: any = {}) {
  * Before calling the original method, ensure Cordova and the plugin are installed.
  */
 export function CordovaProperty(target: any, key: string) {
+  const pluginInstance = getPlugin(target.pluginRef);
   const exists = () => {
-    let pluginInstance = getPlugin(target.pluginRef);
-    if (!pluginInstance) {
+    if (!pluginInstance || pluginInstance[key] === 'undefined') {
       pluginWarn(target, key);
       return false;
     }
@@ -420,14 +419,14 @@ export function CordovaProperty(target: any, key: string) {
   Object.defineProperty(target, key, {
     get: () => {
       if (exists()) {
-        return getPlugin(target.pluginRef)[key];
+        return pluginInstance[key];
       } else {
-        return {};
+        return null;
       }
     },
     set: (value) => {
       if (exists()) {
-        getPlugin(target.pluginRef)[key] = value;
+        pluginInstance[key] = value;
       }
     }
   });

src/plugins/push.ts

@@ -36,7 +36,7 @@ export interface NotificationEventResponse {
   /**
    * An optional collection of data sent by the 3rd party push service that does not fit in the above properties.
    */
-  additionalData: NotificationEventAdditionalData;
+  additionalData: NotificationEventAdditionalData | any;
 }
 
 /**

src/plugins/sqlite.ts

@@ -21,7 +21,7 @@ declare var sqlitePlugin;
  * })
  *   .then((db: SQLite) => {
  *
- *     db.executeSql('create table danceMoves(name VARCHAR(32))').then(() => {}).catch(() => {});
+ *     db.executeSql('create table danceMoves(name VARCHAR(32))', {}).then(() => {}).catch(() => {});
  *
  *   })
  *   .catch(error => console.error('Error opening database', error);

src/plugins/video-player.ts

@@ -41,7 +41,7 @@ export interface VideoOptions {
  */
 @Plugin({
   pluginName: 'VideoPlayer',
-  plugin: 'cordova-plugin-videoplayer',
+  plugin: 'https://github.com/moust/cordova-plugin-videoplayer',
   pluginRef: 'VideoPlayer',
   repo: 'https://github.com/moust/cordova-plugin-videoplayer',
   platforms: ['Android']