fix #36: setting basic authentication not working correctly

test/js-mocha-specs.js

@@ -15,6 +15,9 @@ describe('Advanced HTTP www interface', function() {
   this.timeout(900000);
 
   beforeEach(() => {
+    // mocked btoa function (base 64 encoding strings)
+    global.btoa = decoded => new Buffer(decoded).toString('base64');
+
     mock('cordova/exec', noop);
     mock(`${PLUGIN_ID}.angular-integration`, { registerService: noop });
     mock(`${PLUGIN_ID}.cookie-handler`, {});
@@ -91,4 +94,9 @@ describe('Advanced HTTP www interface', function() {
 
     http.get('https://www.google.de/?gws_rd=ssl', {}, { myKey: 'myValue' }, noop, noop);
   });
+
+  it('sets basic authentication header correctly', () => {
+    http.useBasicAuth('name', 'pass');
+    http.headers['*'].Authorization.should.equal('Basic bmFtZTpwYXNz');
+  });
 });

www/advanced-http.js

@@ -151,8 +151,7 @@ var http = {
         return {'Authorization': 'Basic ' + b64EncodeUnicode(username + ':' + password)};
     },
     useBasicAuth: function (username, password) {
-        this.headers['*'] = this.headers['*'] || {};
-        this.headers['*'].Authorization = 'Basic ' + b64EncodeUnicode(username + ':' + password);
+        this.setHeader('*', 'Authorization', 'Basic ' + b64EncodeUnicode(username + ':' + password));
     },
     setHeader: function () {
         // this one is for being backward compatible